search

dbordak / telephone-line

A new implementation of Powerline for Emacs
GNU General Public License v3.0
560 stars 49 forks source link

Added minions-mode-segment, compatible with minions #92

Closed sebasmonia closed 6 years ago

sebasmonia commented 6 years ago

The new segment shows the major mode plus the small lighter and menu just like https://github.com/tarsius/minions does in the vanilla mode-line.

Kudos for making telephone-line so easy to configure. Creating and testing the segment took me 5 minutes once I figured out how other segments were defined :)

sebasmonia commented 6 years ago

This should close https://github.com/dbordak/telephone-line/issues/90

dbordak commented 6 years ago

Should probably guard this with a when-bound-and-true-p although I guess it might not cause issues when it's being used like this?

Also, I put in a proper docstring for the hud func so you don't need that now :P

sebasmonia commented 6 years ago

I didn't follow on the when-bound-and-true-p comment and couldn't find any clear info :) Assuming the idea is to check that minions is enabled, and the variable is bound??? Let me know so I add the check.

dbordak commented 6 years ago

If using this segment without having minions-mode enabled (or installed) doesn't cause spam in the message/warning buffers, then you're fine with this :)