dborth / fceugx

FCE Ultra GX - Port of FCEUX for Wii
http://wiibrew.org/wiki/FCE_Ultra_GX
283 stars 45 forks source link

[Issue]: APU pitch sweep not correct #465

Closed zoinknoise closed 2 years ago

zoinknoise commented 2 years ago

Describe the bug

pitch sweep doesn't start high enough after a KO in Punch-Out. sounds almost more like beeping instead of the super-fast downward pitch sweep as heard on real hardware. happens with 3.5.1 and the latest nightly from Feb 27.

To Reproduce

play Punch-Out and knock down Glass Joe.

Expected behavior

the sound that plays when the opponent falls should be a very fast downward pitch sweep spanning several octaves.

Relevant log output

No response

Screenshots

No response

dborth commented 2 years ago

this is likely a bug in the upstream emulator (FCEUX). Regardless, sorry I have no intention to fix this myself. If someone wants to submit a PR that does, I'm happy to merge it!

zoinknoise commented 2 years ago

i understand. this issue was actually fixed in FCEUX v2.3.0, which is why i reported the bug here.

saulfabregwiivc commented 2 years ago

i understand. this issue was actually fixed in FCEUX v2.3.0, which is why i reported the bug here.

Try using this fork of FCE Ultra GX made by Tanooki16, FCEUX TX. It's based on most recent FCEUX 2.6.4. https://gbatemp.net/threads/fceugx-1up.558023/

saulfabregwiivc commented 2 years ago

I think this is fixed on FCEUGX with this commit: https://github.com/dborth/fceugx/commit/f7306d1f412914edf3bdb15bf08d85338be9da3b