search

dborth / snes9xgx

Snes9x GX - Port of Snes9x for Wii
http://wiibrew.org/wiki/Snes9x_GX
Other
435 stars 64 forks source link

Snes9x - Backport multiple GFX changes #1002

Closed bladeoner closed 2 years ago

bladeoner commented 2 years ago

@dborth this combines multiple changes in one, I'm not able to test this so please test the changes before committing it.

Snes9x - Create output buffer in core. Snes9x - libretro: Fix audio when video rendering is disabled Snes9x - Use MAX_SNES_HEIGHT, not SNES_HEIGHT_EXTENDED. Snes9x - Remove Settings.SupportHires

Thanks in advance.

bladeoner commented 2 years ago

I asked on GBAtemp if someone could test it and it works, so you can go ahead and merge the PR if you want: https://gbatemp.net/threads/snes9x-gx-4-4-0-beta-feedback-requested.521929/page-26

saulfabregwiivc commented 2 years ago

As i told on GBAtemp, the new build with these changes just got the video worse. https://gbatemp.net/threads/snes9x-gx-4-4-0-beta-feedback-requested.521929/post-9812820

Maybe you need to review this code? (Sorry i'm new in coding so i can't help with that :P)

bladeoner commented 2 years ago

As i told on GBAtemp, the new build with these changes just got the video worse. https://gbatemp.net/threads/snes9x-gx-4-4-0-beta-feedback-requested.521929/post-9812820

Maybe you need to review this code? (Sorry i'm new in coding so i can't help with that :P)

Thanks for the feedback, it's a little bit difficult to troubleshoot if I cannot test it myself.

@dborth if you have some time can you take a look?

bladeoner commented 2 years ago

Did another attempt, couldn't get it to work I will close the PR.