dborth / snes9xgx

Snes9x GX - Port of Snes9x for Wii
http://wiibrew.org/wiki/Snes9x_GX
Other
432 stars 63 forks source link

[Issue]: Gamecube builds not working #1051

Closed niuus closed 1 year ago

niuus commented 1 year ago

Describe the bug

Gamecube builds stopped working after 4.5.3. They load to a black screen.

Using: Pre-release and a new compile from the downloaded source.

Tested with SD Gecko+SD Media Launcher disc, or booting the snes9xgx dol through Swiss (1400-1420). Also changed SD cards with a freshly formatted one, same result.

To Reproduce

Open the DOL.

Expected behavior

Should work, as 4.5.3 version.

Relevant log output

No response

Screenshots

No response

dborth commented 1 year ago

Unfortunately I don't have a way to test on GameCube so I don't have a way to track down which commit broke this.

bladeoner commented 1 year ago

@niuus this week some changes where added, can you try with the latest Pre-release?

If the Pre-release is not working you can test the following files, which contain the three commits after version 4.5.3:

Test1, commit: https://github.com/dborth/snes9xgx/commit/e68ae81f3a543ab72b8b9be2cf1f20d772edbe82 Snes9xGX-GameCube-Test1.zip

Test2: commit: https://github.com/dborth/snes9xgx/commit/9b40986b938ac84de873c14be11f55cbb9ae9688 Snes9xGX-GameCube-Test2.zip

Test3: commit: https://github.com/dborth/snes9xgx/commit/88deb038bc28fade37d0f6951a43a885d0404917 Snes9xGX-GameCube-Test3.zip

niuus commented 1 year ago

Hi @bladeoner. Sure, i'll check these builds in some minutes. I'll reply again with the results.

niuus commented 1 year ago

Results are in:

Test 1

Working

Test 2

Working

Test 3

Working

Pre-release (Optimize code (#1060))

Still not working

bladeoner commented 1 year ago

@niuus ok, that's a good start, to narrow down the scope, can you test the next three builds?

Test 1 commit: https://github.com/dborth/snes9xgx/commit/c74bfa27a034f72f872b08b65b85bc1b92828b05 Download: https://github.com/dborth/snes9xgx/suites/10671939935/artifacts/533720654

Test 2 commit: https://github.com/dborth/snes9xgx/commit/890383fa9665ce0cd8eda52adb7d7d34a558660f Download: https://github.com/dborth/snes9xgx/suites/10563630309/artifacts/525665328

Test 3 commit: https://github.com/dborth/snes9xgx/commit/c84d99060ce574c9bacf25f38bf5bb0fa2e7b298 Download: https://github.com/dborth/snes9xgx/suites/10563099731/artifacts/525625876

niuus commented 1 year ago

@niuus ok, that's a good start, to narrow down the scope, can you test the next three builds?

Test 1 commit: c74bfa2 Download: https://github.com/dborth/snes9xgx/suites/10671939935/artifacts/533720654

Test 2 commit: 890383f Download: https://github.com/dborth/snes9xgx/suites/10563630309/artifacts/525665328

Test 3 commit: c84d990 Download: https://github.com/dborth/snes9xgx/suites/10563099731/artifacts/525625876

Hi @bladeoner. None worked, I think the problem is definitely c84d990 #1045. Might be doing something not permitted on the Cube at startup related to the unsupported PAL addition.

If you can do a build with your devkit for #1043, I can confirm you.

bladeoner commented 1 year ago

Hi @niuus, here you go:

Commit 1043: https://github.com/dborth/snes9xgx/commit/d193277ecaabe8b7cfbd69dcb2138f3080846b48 File: Snes9xGX-GameCube#1043.zip

niuus commented 1 year ago

Hi @niuus, here you go:

Commit 1043: d193277 File: Snes9xGX-GameCube#1043.zip

Back to this, sorry for the absence. Okey, so this one finally works. Tanooki16 noticed his mistake and made a fix, that you can check here: https://gbatemp.net/threads/snes9x-rx-a-new-fork.527131/post-10103981

I briefly tested and it works correctly.

bladeoner commented 1 year ago

@niuus can you test the attached file, I opened a PR with the fix: Snes9xGX-GameCube_Video_Fix.zip

Papy-G commented 1 year ago

Happy to see that this build is properly working with both SDGecko and SD2SP2 at last (used to be stuck to 4.4.9 because of that).

Thank you very much.

Ah, and just in case one of you know how to fix this, FCEUGX and VBAGX suffer from the same issues (volume and files management.