search

dborth / snes9xgx

Snes9x GX - Port of Snes9x for Wii
http://wiibrew.org/wiki/Snes9x_GX
Other
438 stars 64 forks source link

Compile fails after updating to latest devkitPro tools #928

Closed bladeoner closed 4 years ago

bladeoner commented 4 years ago

Feature requests will be closed immediately!

Describe the bug Compiling will fail after updating to the latest devkitPro toolkit

To Reproduce Install devkitPro and update all.

Expected behavior After installing the latest devkitPro and start a build it will fail.

Screenshots If applicable, add screenshots to help explain your problem.

Logfile.txt

bladeoner commented 4 years ago

@dborth The warnings can be solved by applying the following structure it seems:

This warning tells us that buffers passed to sprintf should not overlap, so I changed every occurence of sprintf(str, "%sABC", str) to sprintf(str + strlen(str), "ABC")

Source: https://github.com/lwfinger/rtl8188eu/pull/328

But I still cannot figure out why it fails.

carstene1ns commented 4 years ago

Most of the time sprintf is overkill anyway when adding just an extension. strcat can do the same.