GameCube SD2SP2 fixes - Githubissues

dborth / snes9xgx

Snes9x GX - Port of Snes9x for Wii

http://wiibrew.org/wiki/Snes9x_GX

Other

438 stars 64 forks source link

Closed bladeoner closed 3 years ago

bladeoner commented 3 years ago

This fixes loading and saving files using SD2SP2, tested it on a GameCube.

This might fix #952

bladeoner commented 3 years ago

@dborth, these changes are backported from a PR from emukidid: https://github.com/niuus/Snes9xRX/pull/22

dborth commented 3 years ago

Yeah doesn't matter if it's called cardc or port2. that has no impact on this. there's only two things here:

menu.cpp:3992 and 3394 - those indexes should've been updated - I missed that
the auto-mounting was disabled on purpose at the time because detection was busted in libogc. I think that's fixed now.

bladeoner commented 3 years ago

Thanks for the explanation, shall I close the PR?

dborth commented 3 years ago

As always, appreciate the effort and keeping up with what's going on with other projects.