Allow "Original" (240p) render mode in 480p configurations (Taken from niuus' Snes9x RX)

dborth / snes9xgx

Snes9x GX - Port of Snes9x for Wii

http://wiibrew.org/wiki/Snes9x_GX

Other

438 stars 64 forks source link

Allow "Original" (240p) render mode in 480p configurations (Taken from niuus' Snes9x RX) #982

Closed saulfabregwiivc closed 2 years ago

saulfabregwiivc commented 2 years ago

This commit/contribution was taken originally from Snes9x RX, a fork of Snes9x GX by @niuus. More info: https://github.com/niuus/Snes9xRX/commit/4f4627fe

This will allow "Original" render mode to be selectable when using the Wii Options TV Resolution setting for "EDTV or HDTV (480p)" over component cables:

This caters specifically to LCD / LED users with 240p supported displays, since the option was previously hidden. Users with CRT / PVM / BVM displays with supported 480p Progressive Scan mode will also benefit, since no Wii setting switch will be needed for the "Original" 240p mode to be used. Hope this will be added to Snes9x GX soon.

@saulfabregwiivc

saulfabregwiivc commented 2 years ago

Today tested the build with that commit i'm trying to add to main Snes9x GX. It worked like a charm. Tested in Dolphin emulator and works.

Obviously your TV must support 240p resolution for use "Original" when your Wii settings of TV Resolution is in "EDTV or HDTV (480p)".

dborth commented 2 years ago

This is fine, but why are we flipping sharp and soft around?

saulfabregwiivc commented 2 years ago

This is fine, but why are we flipping sharp and soft around?

The original commit from @niuus flipped those settings, but i've tested it in the compiled build in "Actions" and I didn't notice any confusion between that two even when flipped. Well, if you don't want those settings flipped, i will fix them for you in a new commit for this pull request.

saulfabregwiivc commented 2 years ago

Order of Filtered Sharp/Soft settings fixed in my repo https://github.com/saulfabregwiivc/snes9xgx/commit/df64f54bc5bb9f593537549ab303c5f47ead4c04. Now the only edit that is remaining is allowing 240p rendering in 480p setting. (look at "Files changed" in this PR) Hope this will be merged to main Snes9x GX.