search

dborth / vbagx

Visual Boy Advance GX
http://wiibrew.org/wiki/Visual_Boy_Advance_GX
293 stars 36 forks source link

[Issue]: Real Time Clock (RTC) Doesn't work for GBA games. #456

Open Jman1070 opened 11 months ago

Jman1070 commented 11 months ago

Describe the bug

When loading pokemon games, regular or rom hacks like Unbound/Shiny Gold Sigma the RTC does not function at all.

To Reproduce

  1. Have current VBA GX
  2. Load up a pokemon gba game

Expected behavior

Real time clock follows the UTC offset that is in the main menu.

Relevant log output

No response

Screenshots

No response

saulfabregwiivc commented 2 months ago

for official Pokémon GBA games, maybe it's related to the per-game settings applied in source/gamesettings.cpp, but for romhacks sorry we can't help with that since it needs an option called Force-Enable RTC in the GUI, which isn't present in VBA-GX.

https://github.com/dborth/vbagx/blob/ffc8f4aadb674d94b16af664b2d8408b49d4f4f1/source/gamesettings.cpp#L394-L401

i could try setting RTC to ON for Pokémon GBA games later.

EDIT: for reference, WarioWare: Twisted has forced-enabled RTC here: https://github.com/dborth/vbagx/blob/ffc8f4aadb674d94b16af664b2d8408b49d4f4f1/source/gamesettings.cpp#L938-L945

EDIT 2: for another reference, Tantric set this for make gameSettings for GBA games: https://github.com/dborth/vbagx/blob/ffc8f4aadb674d94b16af664b2d8408b49d4f4f1/source/gamesettings.h#L16-L23