search

dbos-inc / dbos-transact-py

Ultra-Lightweight Durable Execution in Python
https://docs.dbos.dev
MIT License
244 stars 7 forks source link

Queued WF Touchups #120

Closed chuck-dbos closed 1 month ago

chuck-dbos commented 1 month ago

Add queue name to WF status + test Get rid of word "job" by renaming system table Add a test inspired by customer case

chuck-dbos commented 1 month ago

Looks good! My only concern is the table name change migration. Agree the new name is better, but I'm worried it's a breaking change that could cause trouble for existing apps and be a big pain for no real user-facing gain.

How would it break existing apps?

kraftp commented 1 month ago

Looks good! My only concern is the table name change migration. Agree the new name is better, but I'm worried it's a breaking change that could cause trouble for existing apps and be a big pain for no real user-facing gain.

How would it break existing apps?

The main issue is if old code and new code run simultaneously, which is possible in the presence of long-lived workflows.

chuck-dbos commented 1 month ago

The main issue is if old code and new code run simultaneously, which is possible in the presence of long-lived workflows.

And we think we have that in python now?

qianl15 commented 1 month ago

The main issue is if old code and new code run simultaneously, which is possible in the presence of long-lived workflows.

And we think we have that in python now?

We have a demo app using this -- the reminder app can sleep many days.

qianl15 commented 1 month ago

I have the same concern of the non-backward compatible change.

chuck-dbos commented 1 month ago

It can't just be old w/ long WFs, it has to also use queued long WFs.

chuck-dbos commented 1 month ago

I can put an updatable view in under the old name for a while if you insist.