search

dbos-inc / dbos-transact-py

Ultra-Lightweight Durable Execution in Python
https://docs.dbos.dev
MIT License
244 stars 7 forks source link

Dependency Versions #134

Closed kraftp closed 1 week ago

kraftp commented 1 week ago

Add compatibility with older versions of psycopg as newer versions don't support all Python installations.

devhawk commented 1 week ago

From the github action run image

kraftp commented 1 week ago

From the github action run image

Yes, we're adding compatibility with old versions, not changing our dependency. Of course the new version is preferred, but now we work with the old version.

devhawk commented 1 week ago

from https://pdm-project.org/en/latest/usage/lockfile

PDM installs packages exclusively from the existing lock file named pdm.lock. This file serves as the sole source of truth for installing dependencies.

kraftp commented 1 week ago

from https://pdm-project.org/en/latest/usage/lockfile

PDM installs packages exclusively from the existing lock file named pdm.lock. This file serves as the sole source of truth for installing dependencies.

Sure, that's what PDM's local installation does, but the actual MANIFEST file distributed with the wheel is based off the dependencies in pyproject.toml.

devhawk commented 1 week ago

Yes, we're adding compatibility with old versions, not changing our dependency. Of course the new version is preferred, but now we work with the old version.

AFAIK, changing the pyproject.toml file doesn't actually change anything if there's a pdm.lock file present.

kraftp commented 1 week ago

Yes, we're adding compatibility with old versions, not changing our dependency. Of course the new version is preferred, but now we work with the old version.

AFAIK, changing the pyproject.toml file doesn't actually change anything if there's a pdm.lock file present.

Nope, the MANIFEST in the wheel is based off of pyproject.toml. Unpack the wheel and see for yourself :)