search

dbos-inc / dbos-transact-ts

The TypeScript framework for backends that scale
https://docs.dbos.dev
MIT License
366 stars 27 forks source link

Implement durable timeout in workflow getEvent #559

Closed demetris-manikas closed 3 months ago

demetris-manikas commented 3 months ago

This PR aims to add durable timeout to the getEvent method of system_database

demetris-manikas commented 3 months ago

@qianl15 I added the lines that create the problem I mentioned in the PR about recv durable timeout. A lot of tests are failing.... What is going on? I have no clue....

qianl15 commented 3 months ago

@qianl15 I added the lines that create the problem I mentioned in the PR about recv durable timeout. A lot of tests are failing.... What is going on? I have no clue....

I found the workflow-getevent-retrieve test was written in a hacky way that caused the issue. Fixed in this PR: https://github.com/dbos-inc/dbos-transact/pull/560 I tested on my end with the new functionIDGetIncrement call in getEvent and it works. Could you pull latest changes from main and try again?

demetris-manikas commented 3 months ago

After your fix everything went smoothly. Ready for review.