Closed demetris-manikas closed 3 months ago
Rebased and waiting review
Suggestions applied
Happy to help.
I guess you are not interested in implementing the topics
functionality along with topic
since you did not comment on it.
I think that would also be a good change, if slightly more involved
Shoot.. The 'topic' way is deprecated. Should have been an array from the start, I guess it is too late to change the Decorator so I have to create another one or have topic defined as string | RegExp | Array<string | RegExp> which is not that bad except for the variable name. Apart from that the implementation is quite easy. Which way you recommend?
Defining topic
in our decorator as string | RegExp | Array<string | RegExp>
makes the most sense to me.
kafkajs provides support for it so why not expose it?
This can be extended so as to receive an Array<string | RegExp> instead of just one.