search

dbos-inc / dbos-transact

The TypeScript framework for backends that scale
https://docs.dbos.dev
MIT License
291 stars 20 forks source link

add the --report-unused-disable-directives to lint script #441

Closed demetris-manikas closed 2 months ago

demetris-manikas commented 2 months ago

This PR adds the --report-unused-disable-directives which removes all unused eslint disable directives.

It also adds a .eslintignore file that excludes the .eslintrc.cjs file. This is because after enabling the Microsoft eslint plugin in VSCode it complains about this Many ways to solve it and I picked the easiest one. Really why the .cjs extension? why not .js or '.json' ?

qianl15 commented 2 months ago

Thank you! One formatting nit is that --report-unused-disable-directives seems to replace the disable directives lines with empty lines. Can you remove those new empty lines?

This PR is also conflicting with main, please resolve conflicts.

We will clean up eslint config. I filed an issue to track this.

demetris-manikas commented 2 months ago

I tried renaming eslintconfg.cjs to eslintconfg.js and immediately realized want you were talking about... There is a duplicate parserOptions...