search

dbousque / batch_jaro_winkler

Fast batch jaro winkler distance implementation in C99 with Ruby, OCaml and Python bindings.
MIT License
27 stars 4 forks source link

Windows Compatibility #9

Closed paul70131 closed 11 months ago

paul70131 commented 11 months ago

Fixes compilation errors on Windows 10

dbousque commented 11 months ago

Hi @paul70131 . Thank you for your PR! I adapted it a bit in the chore/windows_compatibility branch on the main repo. Can you pull this branch and check if it works locally for you? You can run the python tests to try it out for example:

cd python && pip install -r dev-requirements.txt && ./local_build.sh && cd test && pip install -r requirements.txt && pytest -vv -s
paul70131 commented 11 months ago

Hi, Yes, the chore/windows_compatibility branch compiles and passes all tests locally.

The local_build.sh and cython_build.sh however do not work on Windows, are those files for development only?

dbousque commented 11 months ago

Ok nice thank you. Those are bash/sh scripts, they might not work on Windows depending on your shell. batch_jaro_winkler version 0.1.3 has been published with your changes. Can you try installing this new version and let me know of the result?

paul70131 commented 11 months ago

pip install batch_jaro_winkler worked without any problems and all tests still pass. Thank you!

dbousque commented 11 months ago

Nice! Thank you for the contribution.