dbpedia / databus

A digital factory platform for managing files online with stable IDs, high-quality metadata, powerful API and tools for building on data: find, access, make interoperable, re-use
Apache License 2.0
36 stars 16 forks source link

File browser filters on group page not working correctly #161

Open manonthegithub opened 5 months ago

manonthegithub commented 5 months ago
image

On the screenshot geo-coordinates filter didn't work

m1ci commented 5 months ago
Screenshot 2024-01-11 at 10 19 41
m1ci commented 5 months ago

also, why the artifacts are hard-coded?

2022.12.01

https://databus.dbpedia.org/marvin/generic

en

PREFIX rdfs:   <http://www.w3.org/2000/01/rdf-schema#>
PREFIX rdf:    <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX dcat:   <http://www.w3.org/ns/dcat#>
PREFIX dct:    <http://purl.org/dc/terms/>
PREFIX dcv: <https://dataid.dbpedia.org/databus-cv#>
PREFIX databus: <https://dataid.dbpedia.org/databus#>
SELECT ?file WHERE
{
    GRAPH ?g
    {
        ?dataset databus:group <https://databus.dbpedia.org/marvin/generic> .
        { ?distribution <https://dataid.dbpedia.org/databus-cv#lang> 'en' . }
        { ?distribution <http://purl.org/dc/terms/hasVersion> '2022.12.01' . }
        {
            ?dataset databus:artifact <https://databus.dbpedia.org/marvin/generic/anchor-text> .
        }
        UNION
        {
            ?dataset databus:artifact <https://databus.dbpedia.org/marvin/generic/article-templates> .
        }
        UNION
        {
            ?dataset databus:artifact <https://databus.dbpedia.org/marvin/generic/categories> .
        }
        UNION
        {
            ?dataset databus:artifact <https://databus.dbpedia.org/marvin/generic/citations> .
        }
        UNION
        {
            ?dataset databus:artifact <https://databus.dbpedia.org/marvin/generic/commons-sameas-links> .
        }
        UNION
        {
            ?dataset databus:artifact <https://databus.dbpedia.org/marvin/generic/disambiguations> .
        }
        ?dataset dcat:distribution ?distribution .
        ?distribution databus:file ?file .
    }
}
manonthegithub commented 5 months ago

@m1ci

also, why the artifacts are hard-coded?

2022.12.01

https://databus.dbpedia.org/marvin/generic

en

I don't think they are :). The query is generated just like this with artefact names as consts...

m1ci commented 5 months ago

there are many more artifacts and the question is why they are not in the query?

holycrab13 commented 5 months ago

The query generator was being passed the wrong array of artifacts (the currently displayed ones instead of all) The first issue still persists, the query generator is not working correctly here.

there's no hard-coded SPARQL, the queries are generated.

holycrab13 commented 5 months ago

Working on a fix

JJ-Author commented 5 months ago

what @manonthegithub wrote seems duplicate to this here https://github.com/dbpedia/databus/issues/124 but @m1ci thing might be something different. but I am not sure. so maybe rename/clarify/clean up the issue if its not already fixed.

holycrab13 commented 5 months ago

possible fix deployed on dev