dbpedia / gstore

Git repo / triple store hybrid graph storage
Apache License 2.0
3 stars 0 forks source link

Wiki - Specify Author #37

Closed JonathanJustavino closed 1 month ago

JonathanJustavino commented 2 months ago

It should be possible to set an author when saving a document. The provided author should appear as the author in the git history.

manonthegithub commented 2 months ago

IN git you usually specify Name and Email, what kinda data you want to specify for Author? I suppose at least email... do you want to specify a name too?

JonathanJustavino commented 2 months ago

For now an arbitrary string suffices, passed via query parameter "author". E.g. --author="John Doe <>"

manonthegithub commented 2 months ago

Okay then what should I put as email? As long as I remember Git requires both, so I have to specify anyways both

manonthegithub commented 2 months ago

@JonathanJustavino now it is like that: .setCommitter("databus", "databus@infai.org")

if we put only name, what should I put for email (I can try to put name, not sure if git will allow that, generally email is necessary)? if we put email, I can just duplicate it for name, here no problem other options?

JonathanJustavino commented 2 months ago

The requirement is to leave the email empty, e.g. ?author="databus"&email="<>" or --user "John Doe < >", if that is possible.

holycrab13 commented 2 months ago

To avoid confusion:

what we want:

why do we want it:

Git requires a username and email, but when doing git commit --user "John Doe <>" it leaves the email empty, so I assume this is also possible in the scala API.

You could go with two query parameters ?author and ?email and set whatever is there. Should any of that fail, you could fall back to a default when not specified.

manonthegithub commented 2 months ago

Okay, looks clear now. l will check it out

manonthegithub commented 1 month ago

@holycrab13 @JonathanJustavino this should work now, please check

manonthegithub commented 1 month ago

@holycrab13 @JonathanJustavino dev branch!

holycrab13 commented 1 month ago

Thank you, will have a look!