dbpedia / lookup

Outputs a list of ranked DBpedia resources for a search string.
Apache License 2.0
185 stars 39 forks source link

Add JSON support and domain objects, update pom dependencies and some refactoring #1

Closed matth closed 11 years ago

matth commented 11 years ago

Update pom.xml dependencies

I have extended the object graph returned by the Searcher, this now models concepts such as Categories, OntologyClasses, etc as Scala objects rather than Strings. This was useful as I have started using the lookup codebase from other Scala projects and allows for better interaction with the data.

I refactored the XML serialization to use Scala's built in XML handling. This is type safe and compiler checked so less error prone. It also removes the need for the commons-lang dependency. I have also added JSON serialization via the lift-web json library.

I have added a couple of unit / integration test scenarios. The most useful is probably the full integration test which starts with some raw ntriples, builds a small index then uses the Jersey client over HTTP to interogate an embedded server.

I replaced the System.err.println calls with a Logback logger which should be more configurable to a user's preference

pablomendes commented 11 years ago

@maxjakob I read through the code. This looks like a superb contribution to me. I am itching to merge.

I just want to give you a chance to look over it, as you know the code much better than me.

maxjakob commented 11 years ago

Fantastic! :metal: Gave @matth push rights to this repo.

pablomendes commented 11 years ago

:+1:

matth commented 11 years ago

Thanks a lot guys!