dbr / tvdb_api

Simple to use interface to TheTVDB.com API in Python

The Unlicense

339 stars 63 forks source link

prevent errors due to non-conforming tvdb api response #81

Open mueslo opened 4 years ago

mueslo commented 4 years ago

fixes #73 / #85

codecov[bot] commented 4 years ago

Codecov Report

Merging #81 into master will decrease coverage by 0.49%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   82.42%   81.92%   -0.50%     
==========================================
  Files           1        1              
  Lines         495      498       +3     
==========================================
  Hits          408      408              
- Misses         87       90       +3

Impacted Files	Coverage Δ
tvdb_api.py	`81.92% <50.00%> (-0.50%)`	:arrow_down:

dbr commented 4 years ago

Thanks for this! I'll look at merging this in as soon as I can - I may implement it slightly differently, I'd rather a more specific check than catching tvdb_error as there could potentially be legitimate problems retrieving the actors info which shouldn't be suppressed

mueslo commented 4 years ago

Any update? This is still a critical issue 😢

Back when I wrote this I also reported it to TheTVDB where it was supposedly ticketed to be fixed, but so far nothing has changed. Instead, they seem to be focusing on yet another major non-backwards-compatible API release...

mueslo commented 4 years ago

I opened a ticket after not receiving a response on https://forums.thetvdb.com/viewtopic.php?f=41&t=65534 and it will NOT be fixed (only in their next version of the API). So it is critical to have a workaround...