search

dbr / tvnamer

Automatic TV episode file renamer, uses data from thetvdb.com via tvdb_api
https://pypi.python.org/pypi/tvnamer/
The Unlicense
912 stars 115 forks source link

add config option for using dvd episode order #105

Closed hoax92 closed 9 years ago

dbr commented 9 years ago

Thanks! I think this feature has been requested a couple of times

A few hopefully minor things:

I think it would be tidier having a single argument like --order aired or --order dvd instead of separate arg for each (because there's no case where you'd want to specify both)

Similarly, should store the option in the config as a "aired"/"dvd" string instead of true/false (as it's not immediately obvious what dvdorder:false does)

Oh, and could you add a simple test case for this? Just duplicate one of the functions in test_functional.py, set the new config option and change the expected file names

hoax92 commented 9 years ago

hi,

thanks for your review! changes done.

BR

dbr commented 9 years ago

Looks good - merged, thanks!

hoax92 commented 9 years ago

thank you!

dbr commented 8 years ago

Belatedly released as tvnamer 2.4 - thanks again!