search

dbr / tvnamer

Automatic TV episode file renamer, uses data from thetvdb.com via tvdb_api
https://pypi.python.org/pypi/tvnamer/
The Unlicense
909 stars 115 forks source link

main.py is not included in PyPI release #147

Closed sandrotosi closed 4 years ago

sandrotosi commented 6 years ago

main.py file is missing from pypi release, ie tvnamer is unusable if installed from there

dbr commented 6 years ago

Strange - could you test the newly made 2.5 release? Seems to work for me:

$ mkvirtualenv tvn25test
...
$ pip install tvnamer==2.5
...
$ tvnamer --help
Usage: tvnamer [options] <files>

Options:
...
dbr commented 4 years ago

Shall close this for now; reopen if this is still an issue

sandrotosi commented 4 years ago

if you didnt update MANIFEST.in to include main.py then yes, this is still an issue (we are using 2.5 already)

dbr commented 4 years ago

Hmm, the manifest doesn't contain main.py but the Python source files should be included by default:

$ tar tf tvnamer-2.5.tar.gz  | grep main
tvnamer-2.5/tvnamer/main.py

Can you give more details on what troubles this is causing? The files seem present in the archive and it installs successfully via pip as far as I can tell

dbr commented 4 years ago

Ohh, just realised you are probably referring to the top-level main.py, https://github.com/dbr/tvnamer/blob/master/main.py

I forgot that still existed! I'm kind of tempted to remove this as it's mostly a legacy of the old structure of the code, which was left there was the unittests use it

How are you using main.py? Is there some other approach which would work for this? (I'm thinking of allowing python -m tvnamer ... to work as that seems more conventional these days, e.g python -m venv)

dbr commented 4 years ago

In latest master, the top-level main.py has been removed and in it's place you can do python -m tvnamer if the entrypoint script is unsuitable for whatever reason