dbr / tvnamer

Automatic TV episode file renamer, uses data from thetvdb.com via tvdb_api
https://pypi.python.org/pypi/tvnamer/
The Unlicense
912 stars 115 forks source link

When using valid_extensions in a custom config file, recursive search doesn't work #36

Closed jverdeyen closed 12 years ago

jverdeyen commented 13 years ago

When I change the following line from this: "valid_extensions": ["avi","mp4","m4v","wmv","mkv","mov","srt"], to this: "valid_extensions": [],

recursive searching for files suddenly work, otherwise it says there are no files.

"recursive": true and also tried the -r and --recursive command

Is it possible that dirs get ignored because they are not valid?

dbr commented 13 years ago

Strange, quickly looked at the code and it seems correct - if the valid_extensions list is empty it should assume all extensions are valid, and the check is only done against the filenames

What version are you using? There was a fix for the recursive search a while ago, http://dbr.lighthouseapp.com/projects/36049/tickets/78

jverdeyen commented 13 years ago

I have the same issue as you pointed me to above. But how can I fix it in the current version?

dbr commented 13 years ago

You should just have to update to the latest version - how did you install tvnamer?

jverdeyen commented 13 years ago

I installed it on my Qnap with easy_install. But I found a work arround for this 'problem' I have, I added an empty string to the array of valid extensions.

dbr commented 12 years ago

I've uploaded a much newer version to PyPI, hopefully that should contain the proper fix..

dbr commented 12 years ago

Yep, 2.1 contained this bug, the recent 2.2 contains the fix \o/