search

dbr / tvnamer

Automatic TV episode file renamer, uses data from thetvdb.com via tvdb_api
https://pypi.python.org/pypi/tvnamer/
The Unlicense
912 stars 115 forks source link

Docs: clarify whether extension matching is case sensitive #85

Open felciano opened 10 years ago

felciano commented 10 years ago

The configuration allows you to specify valid extensions -- could be nice to document explicitly whether these are case sensitive or not:

# When non-empty, only look for files with this extension.
# No leading dot, for example: ['avi', 'mkv', 'mp4']
'valid_extensions': [],
lahwaacz commented 10 years ago

All filename handling in Tvnamer is of course case sensitive - but note that the actual behaviour depends on the filesystem, e.g. FAT is always case-insensitive and NTFS only optionally.[1] I don't think this is necessary to document explicitly, this is nowadays the ordinary behaviour.

dbr commented 10 years ago

This is worth mentioning - it would be quite reasonable to assume the filename comparison might be if ext.lower() in Config['valid_extensions']: (which probably isn't a bad idea..)

Pretty sure filesystem insensitivity wouldn't make any difference here - e.g HFS+ Case Insensitive would allow you to make blah.aVI and it wouldn't match against the configured .avi