search

dbrand666 / usmobile-lifeguard

Minds your USMobile pool so you don't have to
GNU General Public License v3.0
15 stars 2 forks source link

feat: check env var if config value unset #3

Closed matthewadams closed 1 year ago

matthewadams commented 1 year ago

Closes #1

matthewadams commented 1 year ago

They're fine for insensitive values and defaults. For secrets (tokens, passwords, etc), environment variables are more common. Plus, it abides by 12-factor principles better -- see 12factor.net.

matthewadams commented 1 year ago

Further, env vars should actually override values on disk, normally, so I'd rather change that now.

matthewadams commented 1 year ago

Ok, addressed all comments & changed behavior to consider env vars before file config, as is convention in 12-factor apps.