search

dbrattli / Expression

Pragmatic functional programming for Python inspired by F#
https://expression.readthedocs.io
MIT License
421 stars 30 forks source link

Fix map's change (issue 105) #106

Open matiboy opened 1 year ago

matiboy commented 1 year ago

Add simple test for change

matiboy commented 1 year ago

Tinkering with this PR and tests made me realize what I think is another issue:


m1 = Map.empty().add('a',1)
m2 = Map.empty().add('a',1).add('b',2)

m1 == m2 # True
m2 == m1 # False
dbrattli commented 1 year ago

Hi @matiboy. I didn't see your PR before I fixed the change bug. But it looks like you have found another bug as well. Anyways, I would like to keep your tests from this PR. Then we should investigate the other issue you found.

matiboy commented 1 year ago

Hi @matiboy. I didn't see your PR before I fixed the change bug. But it looks like you have found another bug as well. Anyways, I would like to keep your tests from this PR. Then we should investigate the other issue you found.

Hi @dbrattli Sure please feel free to copy the test into main/your own branch and close this PR, no issue.