dbrattli / Expression

Functional programming for Python

https://expression.readthedocs.io

MIT License

470 stars 31 forks source link

Fix pydantic validate and pickle for tagged union #207

Closed denghz closed 1 month ago

denghz commented 3 months ago

206 pydantic validate issue

208 pickle issue

denghz commented 1 month ago

@dbrattli I wanted to check in this PR. Could you let me know when it can be merged? If there are any concerns or further testing needed, please let me know.

dbrattli commented 1 month ago

@denghz Sorry for the delay. I've been busy lately. Let's work together to get this merged.

dbrattli commented 1 month ago

FYI: I'm ready to merge this when conflicts are resolved, and we have removed that new comment in tagged_union.py.

denghz commented 1 month ago

Thanks I will do it today. Also I am fixing another bug about model_dump_json and will try to finish it this weekend.

denghz commented 1 month ago

FYI: I'm ready to merge this when conflicts are resolved, and we have removed that new comment in tagged_union.py.

I have removed the comment