use pcmanfm for Lubuntu 18.04 and pcmanfm-qt for newer (Lubuntu 18.10+)

dbrennand / Wallie

Wallie is a CLI which can set your device desktop wallpaper!

GNU General Public License v3.0

6 stars 0 forks source link

use pcmanfm for Lubuntu 18.04 and pcmanfm-qt for newer (Lubuntu 18.10+) #8

Closed ghost closed 5 years ago

ghost commented 5 years ago

Set different pcmanfm call for different Lubuntu versions...

ghost commented 5 years ago

Patch for #4

ghost commented 5 years ago

This patch works on Lubuntu 18.04 (default to LXDE), and this should work on Lubuntu 18.10 and newer (default to LXQT) as well. I didn't test on Lubuntu 18.10 yet. I think you (@Dextroz) should give it a try on your own 18.10 first.

This patch should also work on Lubuntu below than 18.04 that use pcmanfm and LXDE by default.

ghost commented 5 years ago

Hey @momozor thanks for the PR and the testing 👌

The changes are great! 👍 It works perfectly on Lubuntu 18.10 (just tested 😃 )

Could you bump the version number in wallie.py to 1.3.1 please?
And if you want, go ahead and add yourself to the contributors heading near the end of the README.md 😄

ghost commented 5 years ago

Yeah sure. Done.

ghost commented 5 years ago

Perfect, thanks! 😄 👍