Unreleased fix for contrast

dbrgn / RPLCD

A Raspberry Pi LCD library for the widely used Hitachi HD44780 controller, written in Python. GPIO (parallel) and I²C modes supported.

https://rplcd.readthedocs.io/en/latest/

MIT License

262 stars 72 forks source link

Unreleased fix for contrast #111

Closed TojikCZ closed 4 years ago

TojikCZ commented 4 years ago

Hi, I need to include your lib in a project, but want the contrast controll turned off. I see the code is fixed but not released. Like this, I can either:

Include the git path in my requirements making my project use potentially unstable code
Fork this and release it myself freezing that version in time
Specify the contrast pin, not use it and mark it as used artificially lowering the available pins

Or I can ask you to make a release. Could you please please please do that? Thank you

dbrgn commented 4 years ago

Hi. Yep, you're right, I'll definitely try to make a release soon!

I'm quite busy today and tomorrow, so if I forget about this, please remind me by the weekend.

TojikCZ commented 4 years ago

Will do, thank you for the quick reply

TojikCZ commented 4 years ago

Hi, I'm facing skipped characters, but the pigpio and gpio implementations are different, one not supporting the compat thing. Moreover, there is a freaking while loop without a sleep in there. That's brutal, in my intended application, the pi has to have a lot more CPU left over. I'm gonna fork this and come back when I have something "better". Maybe wait with that release after all. :D

dbrgn commented 4 years ago

@TojikCZ if you can get a PR up for that while loop by the weekend, I can probably include that in the release, yes 🙂 and otherwise I can simply create a second release next week.

Unfortunately I don't use the pigpio backend myself, so I fully rely on other testers / contributors.

dbrgn commented 4 years ago

Version 1.3.0 is released.