search

dbrgn / RPLCD

A Raspberry Pi LCD library for the widely used Hitachi HD44780 controller, written in Python. GPIO (parallel) and I²C modes supported.
https://rplcd.readthedocs.io/en/latest/
MIT License
261 stars 72 forks source link

Attempt to fix compat_mode_pigpio #115

Open TojikCZ opened 4 years ago

TojikCZ commented 4 years ago

Hi, after discovering the pull request that was supposed to add the compat mode to the pigpio side i included my changes to make the sleep amount tune-able and to make it stop busy waiting. The wait gets less precise but I don't think that's a big deal, sleep overshoots by 0.15 nano seconds on my pi. There is a lot of sleep requests shorter than that and the code works regardless.

I have another thing ready for a pull request. I made the caching optional as my setup produces too many errors for me to trust it with displaying the text right on the first try.

This is my first time trying to contribute to an open-source project, so criticize everything i do, so I'll learn something new :)

TojikCZ commented 4 years ago

Interested in what the Travis CI will output. I don't have it setup (yet)

TojikCZ commented 4 years ago

rebased on master, squashed ugly fix commits

TojikCZ commented 2 years ago

Feeling pretty ignored over here. Guess I'm deploying with my fork stuck in the time I made it. What could have I done differently to not get stood up?

dbrgn commented 2 years ago

This is my first time trying to contribute to an open-source project, so criticize everything i do, so I'll learn something new :)

@TojikCZ sorry for the late response (especially since this was your first contribution). I have lots of open source projects (plus other obligations and interests as well), and sometimes a GitHub notification e-mail gets overlooked.

What could have I done differently to not get stood up?

A friendly ping after a few weeks of inactivity usually helps to bring the issue to my attention.

Your patch looks pretty simple, so I'll take a look right now.

TojikCZ commented 2 years ago

Sorry, I got a taste of how missable github notifications can be shortly after posting this :sweat_smile: