search

dbrgn / espresso

AT based driver crate for ESP8266 WiFi modules.
Apache License 2.0
9 stars 4 forks source link

Update to latest version of atat #13

Closed fkohlgrueber closed 3 years ago

fkohlgrueber commented 3 years ago

This PR updates espresso to work with the current version of atat.

fkohlgrueber commented 3 years ago

How do you feel about this PR? Atat has in the meantime updated to const generics, but I think it's anyway a good idea to merge this PR before updating to that new Atat version.

Edit: forget that. I just saw that we're currently using atat as a git dependency, so it won't compile currently. I'll update this PR to work with the latest atat version (0.11.0), probably over the weekend or next week. Switching the atat dependency of this crate to a regular atat = "0.11.0" is probably a good idea at this point.

fkohlgrueber commented 3 years ago

Update done, can you take a look? Thanks in advance!

dbrgn commented 3 years ago

I already started a review, but didn't finish it yet, sorry. No time this weekend so far.

I'll try to do it tomorrow.

dbrgn commented 3 years ago

@fkohlgrueber do you plan to continue working on this?

fkohlgrueber commented 3 years ago

Hi @dbrgn, I'm sorry for taking so long to follow up on this. I'd like to use espresso for a hobby project at some point in the future, but this doesn't have any priority and I don't have much time to contribute anymore. I should've responded earlier anyway, sorry for that. I've fixed the issues you pointed out in your review. Is this ready to be merged now?

dbrgn commented 3 years ago

Yeah, thank you! Let's merge this 🙂

dbrgn commented 3 years ago

Oops, seems that compilation doesn't currently work. Seems that the reason is yet another embedded-hal update.

I'll lock it to alpha 4 for now, then we can fix this later.