Closed fkohlgrueber closed 3 years ago
How do you feel about this PR? Atat has in the meantime updated to const generics, but I think it's anyway a good idea to merge this PR before updating to that new Atat version.
Edit: forget that. I just saw that we're currently using atat as a git dependency, so it won't compile currently. I'll update this PR to work with the latest atat version (0.11.0), probably over the weekend or next week. Switching the atat dependency of this crate to a regular atat = "0.11.0"
is probably a good idea at this point.
Update done, can you take a look? Thanks in advance!
I already started a review, but didn't finish it yet, sorry. No time this weekend so far.
I'll try to do it tomorrow.
@fkohlgrueber do you plan to continue working on this?
Hi @dbrgn, I'm sorry for taking so long to follow up on this. I'd like to use espresso for a hobby project at some point in the future, but this doesn't have any priority and I don't have much time to contribute anymore. I should've responded earlier anyway, sorry for that. I've fixed the issues you pointed out in your review. Is this ready to be merged now?
Yeah, thank you! Let's merge this 🙂
Oops, seems that compilation doesn't currently work. Seems that the reason is yet another embedded-hal update.
I'll lock it to alpha 4 for now, then we can fix this later.
This PR updates
espresso
to work with the current version ofatat
.