Closed frinkelpi closed 7 years ago
Thanks! That's quite some changes :) I'll review them this week, hopefully.
But first of all, could you include texttable via PyPI instead of using submodules?
Sure, that's because I had to submit a fix, but the module has now been updated on pypi, and I'll drop the submodule dependency.
I'm getting an exception on the following query:
$ python -m fahrplan.main von burgdorf nach rüti via bern
Traceback (most recent call last):
File "/usr/lib64/python3.5/runpy.py", line 184, in _run_module_as_main
"__main__", mod_spec)
File "/usr/lib64/python3.5/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/danilo/Projects/fahrplan/fahrplan/main.py", line 109, in <module>
main()
File "/home/danilo/Projects/fahrplan/fahrplan/main.py", line 95, in main
data = getConnections(args, (output_format == Formats.FULL), proxy_host)
File "/home/danilo/Projects/fahrplan/fahrplan/API.py", line 134, in getConnections
data["connections"] = [_parse_connection(c, include_sections) for c in data["connections"]]
File "/home/danilo/Projects/fahrplan/fahrplan/API.py", line 134, in <listcomp>
data["connections"] = [_parse_connection(c, include_sections) for c in data["connections"]]
File "/home/danilo/Projects/fahrplan/fahrplan/API.py", line 115, in _parse_connection
section = _parse_section(con_sections[0], connection)
File "/home/danilo/Projects/fahrplan/fahrplan/API.py", line 62, in _parse_section
section['travelwith'] = journey["name"]
TypeError: 'NoneType' object is not subscriptable
And sorry for not reviewing sooner. In the future, sending smaller pull requests makes it easier and faster to review and merge :)
Thanks! If you have further improvements, small pull requests help :)