search

dbrgn / fahrplan

A SBB/CFF/FFS commandline based timetable client. Project started at make.opendata.ch.
GNU General Public License v3.0
132 stars 20 forks source link

Test Python 3.6 on Travis #28

Closed The-Compiler closed 5 years ago

The-Compiler commented 5 years ago

I think that's the default available nowadays.

dbrgn commented 5 years ago

You also need to update tox.ini.

If you want you can update your PR to drop Python 2 support, and then test Python 3.5 and either 3.7 or 3.8 in CI / Tox.

The-Compiler commented 5 years ago

This seems to run without any update to tox.ini - tox has pyXY environments built in. I guess I could update it to use py36 (or py37) by default in envlist and drop the unnecessary [testenv:py35] environment though.

dbrgn commented 5 years ago

Oh, I wasn't aware of that. However, for the users that run tests locally, the Tox config should match the CI config.

The-Compiler commented 5 years ago

Updated! I lack the time to look at dropping Python 2 support at the moment, blame my bachelor thesis :wink:

dbrgn commented 5 years ago

Thanks. The tox config is still missing for 3.6. But feel free to ignore that, I'll incorporate the changes into a separate PR that drops Python 2 support and tests on 3.5 and 3.7. Thanks anyways for bringing it up!

dbrgn commented 5 years ago

See #30. I also dropped TravisCI :tada:

The-Compiler commented 5 years ago

Awesome, thanks! :+1: