dbrgn / heroku-buildpack-python-sklearn

Python buildpack with Numpy 1.7.0, SciPy 0.11.0 and a current version of Scikit-learn.
MIT License
31 stars 28 forks source link

Question #10

Closed bnjmnt4n closed 10 years ago

bnjmnt4n commented 10 years ago

Hi, I'm trying to build a Heroku app which uses matplotlib. According to your README, I should see something like this:

-----> Noticed numpy/scipy. Bootstrapping prebuilt binaries.
-----> Creating/downloading binaries.
-----> Creating/downloading numpy bdist.
-----> Creating/downloading scipy bdist.

However in my build, as far as I can tell they are actually building numpy from scratch. I'm not really good with Python, and it would be great if you could advise me.

dbrgn commented 10 years ago

I never tried deploying via Travis, but if you put your Heroku API_KEY in a public repository, won't it be possible for anyone to deploy malicious apps to your Heroku account?

And regarding the deployment itself, it doesn't look like you're setting the buildpack url. You need to change the deployment somehow (don't know how it works on Travis) to use this repository as buildpack instead of the default.

bnjmnt4n commented 10 years ago

Nope, Travis has secure environment variables, encrypted so that only your builds can have them.

I've already set the buildpack URL using heroku on my local machine. I'm using multi-buildpack to add the default node.js buildpack and this one. I'm retrying the build now, hope it works !

bnjmnt4n commented 10 years ago

Do you have a git SHA where the buildpack was known to be working? Perhaps there's an issue with master.

dbrgn commented 10 years ago

I just tested the demo again (https://github.com/dbrgn/heroku-buildpack-python-sklearn#demo), and everything works fine.

bnjmnt4n commented 10 years ago

You're right, there was an issue with my buildpack. It's now been fixed. Thanks for your help anyway ;)

dbrgn commented 10 years ago

And in the future, you should use this buildpack, as I'm not maintaining my fork anymore: https://github.com/thenovices/heroku-buildpack-scipy