search

dbrgn / miniaturo

A drop-in replacement for raw-thumbnailer.
GNU General Public License v3.0
8 stars 1 forks source link

Add integration tests and CI #9

Closed dbrgn closed 3 years ago

dbrgn commented 3 years ago

Fixes #5.

dbrgn commented 3 years ago

@hfiguiere tests currently fail because libopenraw-3 is not available on Ubuntu. Do your bindings work with libopenraw-1 as well?

The libopenraw-dev package provides a pkg-config file: https://ubuntu.pkgs.org/18.04/ubuntu-universe-amd64/libopenraw-dev_0.1.2-0.2_amd64.deb.html

hfiguiere commented 3 years ago

No they don't. There have been API changes.

dbrgn commented 3 years ago

Ok, too bad, then the bindings won't work for any currently published distro that doesn't do rolling release (Ubuntu, Debian, Fedora...). But I guess that's acceptable. I'll add a note to the README.

dbrgn commented 3 years ago

Maybe Rust allows static linking against C libs, so that libopenraw could be vendored in for systems that haven't installed it systemwide?

hfiguiere commented 3 years ago

There could be an option to build the bindings with a static version of the lib, but this is not on top of my list.