dbrgn / orochi

Orochi is an interactive command line client for 8tracks.com.
GNU General Public License v3.0
86 stars 17 forks source link

search improvements #33

Closed octogene closed 10 years ago

octogene commented 10 years ago

Add search by tag or tags. Add sorting options (recent|popular|hot). Add option to choose number of results per page. Add navigation to next result page.

dbrgn commented 10 years ago

Hm, I'm not 100% sure yet whether I like that search syntax. I'll have to think about it a little.

octogene commented 10 years ago

First idea i came up with, maybe it's a bit too long. We could simplify it by just using a letter in front of the search term : Syntax: search t|ts|u|ul <searchterm> .

dbrgn commented 10 years ago

No, the main issue is that it's very complicated to create "a query language inside the query language". Commands like "search_tags", "search_user" etc would probably be more straightforward and easier to implement.

octogene commented 10 years ago

Ok, i'll refactor the code so we'll have a command for each type of query.

dbrgn commented 10 years ago

Thanks. When you're done, can you rebase your commits against current master and then squash them into a single commit?

That would be helpful and make the history much cleaner. If you're doing it for the first time, make sure to first create a backup of the branch (git checkout -b backup develop && git checkout develop).

octogene commented 10 years ago

I did the rebase and squashed the commits but i'm not sure if it's all good. I'm not a git expert ;)

dbrgn commented 10 years ago

Perfect, thanks! :) That makes for much cleaner commit history.

I'll review the new version when I find time, probably tomorrow.

dbrgn commented 10 years ago

I'll merge for now. Thanks for your contribution, @octogene! :)