search

dbrgn / shtcx-rs

Platform agnostic Rust driver for the Sensirion SHTCx temperature/humidity sensors.
Apache License 2.0
13 stars 4 forks source link

Support for embedded-hal 1.0 #31

Closed ShakenCodes closed 4 months ago

ShakenCodes commented 10 months ago

Breaking changes in embedded-hal 1.0.0-rc.1 are incompatible with this driver. I have a working version at: https://github.com/Radiator-Labs/shtcx-rs, and will submit a PR when the complete build is operational. The driver operates correctly, which I am testomg on an STM32WL55 application.

I am not able to submit the PR at this time, as one of the dev-dependencies, embedded-hal-mock, is not compatible with embedded-hal 1.0.0-rc.1. There is a PR awaiting incorporation, which is tracked by: https://github.com/dbrgn/embedded-hal-mock/pull/86 (Which I now realize is also by you. Thank you for all the goodness!) linux-embedded-hal is up to the new standard, as of: https://github.com/rust-embedded/linux-embedded-hal/pull/96

dbrgn commented 10 months ago

Thanks! I reviewed the embedded-hal-mock PR, once it's merged I think I can push a new release 🙂

dbrgn commented 10 months ago

An updated embedded-hal-mock is now released (0.10.0-rc.1)!

dbrgn commented 7 months ago

By now the embedded-hal 1.0 stable was released, and embedded-hal-mock also has a release that supports it (0.10.0). It was already updated in #33.

I hope I find time in the coming 1-2 weeks to update the driver. Alternatively, PRs are welcome. (But if you start working on it, please comment here first, so that there is no duplicated effort.)

ShakenCodes commented 7 months ago

I may have time in the next couple of days. I think a contractor that has been helping my team may have already fixed this on a branch.

On Jan 13, 2024, at 12:45 PM, Danilo Bargen @.***> wrote:

By now the embedded-hal 1.0 stable was released, and embedded-hal-mock also has a release that supports it (0.10.0). It was already updated in #33 https://github.com/dbrgn/shtcx-rs/pull/33.

I hope I find time in the coming 1-2 weeks to update the driver. Alternatively, PRs are welcome.

— Reply to this email directly, view it on GitHub https://github.com/dbrgn/shtcx-rs/issues/31#issuecomment-1890764824, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6JRQKSQPUBHEYPJHKPFULYOLW4ZAVCNFSM6AAAAAA6YHXWVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQG43DIOBSGQ. You are receiving this because you authored the thread.

ShakenCodes commented 7 months ago

Pull request is submitted, but the GitHub Actions do not seem to be starting.

ShakenCodes commented 5 months ago

I am having problems getting this all to work, especially the library's tests. @dbrgn Would you be open to a virtual pairing session to get this over the finish line? (I am in the Pacific time zone and could be available form reasonably early in the morning and well into the evening. My availability starts in the week of March 18, but I thought it would make sense to start planning now.

dbrgn commented 5 months ago

@ShakenCodes virtual pairing is a bit difficult at the moment, I have quite a full schedule over the next few weeks. what's the main issue you're stuck with?

you could also push your current state, and I could try to pick up from that.