search

dbrgn / shtcx-rs

Platform agnostic Rust driver for the Sensirion SHTCx temperature/humidity sensors.
Apache License 2.0
13 stars 4 forks source link

Release v1.0.0 #39

Closed dbrgn closed 3 months ago

dbrgn commented 4 months ago

Now that embedded-hal 1.0 is out, we can tag 1.x as well.

dbrgn commented 4 months ago

@ShakenCodes @lightyear15 since you recently contributed to this library: Maybe you could quickly test whether the current main branch works without any issues for you, before I publish the release?

ShakenCodes commented 4 months ago

@ShakenCodes @lightyear15 since you recently contributed to this library: Maybe you could quickly test whether the current main branch works without any issues for you, before I publish the release?

It has been tested with my hardware and passes our full automated test suite.

elpiel commented 3 months ago

Hey @dbrgn I was wondering if an async feature can be added to version 1.0 as well?

lightyear15 commented 3 months ago

Hello @dbrgn

tested with my esp32-c3 devkit-rust board and it works as expected thanks

rnestler commented 3 months ago

Hey @dbrgn I was wondering if an async feature can be added to version 1.0 as well?

I don't think it makes much sense to delay the 1.0 release with embedded-hal 1.0. If there is a PR adding async we can just release 1.1 or even 2.0 if it leads to breaking changes.

dbrgn commented 3 months ago

Hey @dbrgn I was wondering if an async feature can be added to version 1.0 as well?

I don't think so, I'd prefer to push out the release soon, and I don't yet have any experience with async in the embedded context.

However, tagging 1.0.0 doesn't mean that async can't be added in a subsequent release. Depending on how it's implemented, it's not even a breaking change.

Edit: Oops, didn't see that @rnestler already replied as well 🙂

dbrgn commented 3 months ago

@ShakenCodes @lightyear15 great, thanks for your testing!