search

dbrgn / tealdeer

A very fast implementation of tldr in Rust.
https://dbrgn.github.io/tealdeer/
Apache License 2.0
4.06k stars 123 forks source link

Bump MSRV to 1.75 #352

Closed dbrgn closed 6 months ago

dbrgn commented 6 months ago

For clap v4 (#298), we need a higher MSRV, currently at least Rust 1.64.

Our MSRV policy is:

When publishing a tealdeer release, the Rust version required to build it should be stable for at least a month.

I'd suggest to jump to 1.75. It's the current stable, released on December 28, and contains the "async fn in traits" change which makes it a potential synchronization point for libraries.

niklasmohrin commented 6 months ago

I think we should stay at 1.64 until we need a higher version. Are there any benefits to upgrading beyond that?

I am just thinking about something like the Debian package which maybe still has an old Rust version

dbrgn commented 6 months ago

Are there any benefits to upgrading beyond that?

As long as we can bump the required Rust version with any new release, probably not. (Debian would be free to use an older version though, as long as it works.)

PR updated to 1.64.