search

dbrgn / tealdeer

A very fast implementation of tldr in Rust.
https://dbrgn.github.io/tealdeer/
Apache License 2.0
4.06k stars 123 forks source link

Updated Benchmark and Fixed Code For Purity and Readable #357

Closed Walker-00 closed 5 months ago

Walker-00 commented 5 months ago

Since The benchmark is made at 2021, almost everything has changed not just for tealdeer almost every tldr clients has been changed so I made a re benchmarking and rewrite some code for readable purpose.

niklasmohrin commented 4 months ago

@Walker-00 I take it you do not want to continue working on this (which is totally fine)? Otherwise, I would suggest that we split the code changes and the benchmark changes into two separate PRs to make reviewing easier

Walker-00 commented 4 months ago

@Walker-00 I take it you do not want to continue working on this (which is totally fine)? Otherwise, I would suggest that we split the code changes and the benchmark changes into two separate PRs to make reviewing easier

Nah bro, I really enjoy contributing to this pj. But I'm a bit busy lately with my startup. I'll keep contributing when I'm free.

niklasmohrin commented 4 months ago

Okay, no worries

Walker-00 commented 4 months ago

yea bro, so should I reopen pull req

niklasmohrin commented 4 months ago

Please leave it closed until you want to resume working on it :)

Walker-00 commented 4 months ago

oki bro