search

dbrgn / tracing-test

Access and evaluate tracing logs in async and sync tests.
Apache License 2.0
62 stars 27 forks source link

ensure correct `Result` type is used #15

Closed JeanMertz closed 2 years ago

JeanMertz commented 2 years ago

This avoids issues when someone defines their own Result type (e.g. type Result<T> = Result<T, ()>), and uses this crate's #[traced_test].

See https://github.com/vectordotdev/vector/pull/12655, for an example of where this happened.

I noticed there were other stdlib types used without fully qualified paths, but I left those alone, as overwriting them seems less likely. I'm happy to change them as well, though, please let me know.

dbrgn commented 2 years ago

Good call, that makes sense! Thanks for the fix.

If you want to submit another PR adding more fully qualified stdlib paths, that would be welcome as well!