search

dbrizov / NaughtyAttributes

Attribute Extensions for Unity
MIT License
4.53k stars 464 forks source link

Fix bug where fields preceding `ExpandableAttribute` were not modifiable (#294) #295

Closed rhys-vdw closed 2 years ago

rhys-vdw commented 2 years ago

Please refer to #294 for my investigation notes and uncertainties around intent of removed line.

Closes #294

dbrizov commented 2 years ago

Great, I will test it and merge it in the weekend :)

rhys-vdw commented 2 years ago

The thing I was most confused by was that this line wasn't added in the commit that introduced the bug. So it's a bit of programming by permutation. You might want to use your brilliant unity editor brain to have a think about whether it's actually treating the cause and not a symptom.

rhys-vdw commented 2 years ago

@dbrizov I'm sure you're a busy man, so I hope you don't mind a nudge on this one. 🙏

dbrizov commented 2 years ago

@dbrizov I'm sure you're a busy man, so I hope you don't mind a nudge on this one. 🙏

@rhys-vdw I know, sorry. I honestly completely forgot to merge it. I started tutoring students, apart from my job, and I barely have any free time. I will try to do my best and merge it as soon as possible. It should be a quick merge anyway :)

dbrizov commented 2 years ago

Merged in v2 7cddf69bca9d09eb8205498ebaf6bdc50f7641fd

rhys-vdw commented 2 years ago

Thanks mate!

dbrizov commented 2 years ago

I thank you. And, yeah sorry for keeping you waiting, thanks for the patience