`openRemoteSimulation()` crashes when run in Jupyter notebook

dbrnz / opencor

OpenCOR is a cross-platform modelling environment which can be used to organise, edit, simulate and analyse CellML files.

http://www.opencor.ws/

GNU General Public License v3.0

1 stars 0 forks source link

`openRemoteSimulation()` crashes when run in Jupyter notebook #24

Closed dbrnz closed 5 years ago

dbrnz commented 5 years ago

All is well when run from OpenCOR's Python console.

An example is:

s = oc.openRemoteSimulation('https://models.physiomeproject.org/w/andre/SAN-ORd/rawfile/fe51425ce5ef054bcf04128f29e22346717def48/action-potential.xml')

dbrnz commented 5 years ago

This is because SEDMLSupport::SedmlFile::cellmlFile() calls Core::centralWidget()->showBusyWidget(); and yet we are not running under a GUI...

@agarny, does this need to be controlled with a pWithBusyWidget parameter as you do in CellMLSupport::CellmlFile::fullyInstantiateImports()`??

agarny commented 5 years ago

Yes, it looks like it needs to be controlled by something like pWithBusyWidget. Please create a GitHub issue in the main repo.

dbrnz commented 5 years ago

Moved issue to opencor/opencor#2085.

dbrnz commented 5 years ago

Fixed by commit 88e670c.