dbry / WavPack

WavPack encode/decode library, command-line programs, and several plugins
BSD 3-Clause "New" or "Revised" License
363 stars 66 forks source link

audition/cool_wv4.c: fix warnings from win64 builds #120

Closed sezero closed 2 years ago

sezero commented 2 years ago
audition/cool_wv4.c: In function 'FilterGetOptions':
audition/cool_wv4.c:772:5: warning: passing argument 4 of 'DialogBoxParamA' from incompatible pointer type
winuser.h:2240:29: note: expected 'DLGPROC' but argument is of type 'BOOL (*)(struct HWND__ *, UINT,  WPARAM,  LPARAM)'
audition/cool_wv4.c: In function 'WavPackDlgProc':
audition/cool_wv4.c:836:77: warning: cast from pointer to integer of different size
dbry commented 2 years ago

Hi, thanks for this, but I have a question about it. On my system the Audition (and Winamp) plugins do not build for win64 because those programs are only 32-bit executables (and I don't think 64-bit DLLs would work). Are you building these as 64-bit DLLs? It may be that this change is worth putting in, but have you tested that it does not break the Audition plugin for 32-bit setups?

sezero commented 2 years ago

I built them as 64 bit as part of a 64 bit build, when I noticed the build warnings. I haven't tested, but there can not be any kind of breakage because of this patch because it only fixes win32 api usage and nothing else.

dbry commented 2 years ago

Okay, I'll bring in the change (seems like a good idea).

But currently the configuration on VS 2019 does not build a 64-bit version of the Audition plugin. Did you override that for testing somehow, or do other versions of VS behave differently with these solution files. I am concerned because I don't want a 64-bit version of the Audition (or Winamp) plugin getting built and confusing someone (because they probably won't work)

Thanks!

sezero commented 2 years ago

Ah, not MSVC: I just built using MinGW.

dbry commented 2 years ago

Ah, thanks, that explains it!