search

dbry / WavPack

WavPack encode/decode library, command-line programs, and several plugins
BSD 3-Clause "New" or "Revised" License
363 stars 66 forks source link

ENABLE_LEGACY mismatch using cmake #128

Closed gitterdude closed 6 months ago

gitterdude commented 1 year ago

When I run cmake on commit 36b08db without any options it says _-- The following features have been disabled: ENABLELEGACY, Decode legacy (< 4.0) WavPack files.

Adding -DENABLE_LEGACY=1 shows _CMake Warning: Manually-specified variables were not used by the project: ENABLELEGACY

The proper way appears to be adding -DWAVPACK_ENABLE_LEGACY=1 , so it should be reflected in the first message

dbry commented 1 year ago

Hi. I am unfortunately not very familiar with cmake, but I found the command cmake -LH and it displayed this, which seems to be the right thing:

// Decode legacy (< 4.0) WavPack files
WAVPACK_ENABLE_LEGACY:BOOL=OFF

I looked at the CMakeLists.txt file and it used both WAVPACK_ENABLE_LEGACY and ENABLE_LEGACY as different things so I don't really know how I would fix this.

Any comments @evpobr ?

Thanks!

evpobr commented 1 year ago

@gitterdude , this happened due to different feature names and options. Generally speaking, this is not an error, they do not have to match and the message does not say to use the ENABLE_LEGACY option anywhere.

@dbry , in general, there is no problem to make the names of features and options match, why not. I will make PR.

evpobr commented 1 year ago

Ready, #129 .