Closed sezero closed 2 years ago
Thanks for these!
You mentioned that you tested the cross-build. Do you mean that you built the winamp plugin on Linux and tested that plugin on Windows using winamp? Which winamp version do you use? I haven't been keeping up with winamp, but it looks like there might be a 64-bit build now. Does that work with the WavPack plugin if it's built for 64-bit, or does it work with old plugins?
@evpobr you're far more experienced with cmake than I am; does this all seem good to go? Thanks!
You mentioned that you tested the cross-build. Do you mean that you built the winamp plugin on Linux and tested that plugin on Windows using winamp?
Build-tested only, not run-tested.
keeping up with winamp, but it looks like there might be a 64-bit build now.
It builds alright, but don't know whether there is a 64 bit winamp (not really interested in it, I just fixed annoyances in the way of build procedure.)
CMake code looks good 👍
LINK_FLAGS
property is managed as a string not a semicolon-separated list.FASTCALL
only if not already defined, and define it as__fastcall
only when targeting i386.DWORD
, not anint
.int32_t
, notlong
.actual_size < 2147483648
comparison so that the constant fits into a signed int.swprintf
calls to_snwprintf
_MSC_VER
is defined when checking its value.NOVTABLE
as__declspec(novtable)
only for_MSC_VER
, not_WIN32
.In_Module mod
more compatible.UTF8ToAnsi()
Build tested on i686 and x86_64 linux using cmake-3.9.6 and 3.11.2. Cross-build tested for i686 and x86_64 using mingw-w64 toolchains.