dbry / WavPack

WavPack encode/decode library, command-line programs, and several plugins
BSD 3-Clause "New" or "Revised" License
371 stars 67 forks source link

multiple cmake and windows build fixes: #132

Closed sezero closed 2 years ago

sezero commented 2 years ago

Build tested on i686 and x86_64 linux using cmake-3.9.6 and 3.11.2. Cross-build tested for i686 and x86_64 using mingw-w64 toolchains.

dbry commented 2 years ago

Thanks for these!

You mentioned that you tested the cross-build. Do you mean that you built the winamp plugin on Linux and tested that plugin on Windows using winamp? Which winamp version do you use? I haven't been keeping up with winamp, but it looks like there might be a 64-bit build now. Does that work with the WavPack plugin if it's built for 64-bit, or does it work with old plugins?

@evpobr you're far more experienced with cmake than I am; does this all seem good to go? Thanks!

sezero commented 2 years ago

You mentioned that you tested the cross-build. Do you mean that you built the winamp plugin on Linux and tested that plugin on Windows using winamp?

Build-tested only, not run-tested.

keeping up with winamp, but it looks like there might be a 64-bit build now.

It builds alright, but don't know whether there is a 64 bit winamp (not really interested in it, I just fixed annoyances in the way of build procedure.)

evpobr commented 2 years ago

CMake code looks good 👍