search

dbsrgits / dbix-class-schema-loader

Official GitHub remote for git.shadowcat.co.uk DBIx-Class-Schema-Loader.git
http://dbix-class.org/
11 stars 34 forks source link

Port to Distar #17

Closed mohawk2 closed 6 years ago

mohawk2 commented 6 years ago

Also includes as discussed a release-test to check existence of opt-dep .pod, and that it's newer than the .pm. The generating is done effectively at perl Makefile.PL-time and should probably instead be a build-time thing.

When I ran the Distar-enhanced make test, I got a xt/whitespace.t fail from a t/var/...something.pm. Probably needs a grep on that but the modules don't seem to offer an "exclude" option.

mohawk2 commented 6 years ago

The CI is failing, looks like it's missing deps like CAG and Test::Exception, probably because the .travis.yml needs updating. I will investigate.

mohawk2 commented 6 years ago

The CI is still failing but now only on CLEANTEST=true. I will investigate this later, but in the meantime if reviewers can look over the CI changes and/or respond further on review points that will be very helpful.

ilmari commented 6 years ago

The Travis failures all seem to be due to dependencies failing to build or install, so not a blocker. I've adjusted things a bit and merged it as fb4432c, and pushed a dev release.

abraxxa commented 6 years ago

What‘s the reason for this change?

mohawk2 commented 6 years ago

@ilmari Let me know if further tweaks are required. I think it would be better for accountability if it were my name/id on https://github.com/dbsrgits/dbix-class-schema-loader/commit/fb4432c55eca639f4c28dbde21b7356dbbcfc853 rather than yours. However, I guess I don't mind you getting the blame ;-)

mohawk2 commented 6 years ago

@abraxxa Moving off Module::Install, less complicated CI, easier release process.