dbsrgits / dbix-class-schema-loader

Official GitHub remote for git.shadowcat.co.uk DBIx-Class-Schema-Loader.git
http://dbix-class.org/
11 stars 34 forks source link

update the dsn in the documented example #20

Closed j1n3l0 closed 6 years ago

j1n3l0 commented 6 years ago

The double quotes appear to have been left in by accident and can lead to connection errors for those not paying close attention.

ilmari commented 6 years ago

Are you actually seeing errors? DBD::Pg allows quoted database names just fine (required if there's e.g. a space in the database name). Other DBDs may vary, but then you have to change the DSN anyway.

j1n3l0 commented 6 years ago

my apologies. i was using mysql and just assumed it was an oversight. will close this now.

FYI: you seem to have a separate issue with your travis-ci build:

The command "maint/getstatus maint/travis-ci_scripts/30_before_script.bash || ( maint/travis-ci_scripts/50_after_failure.bash && /bin/false )" failed and exited with 1 during .