search

dbsrgits / dbix-class-schema-loader

Official GitHub remote for git.shadowcat.co.uk DBIx-Class-Schema-Loader.git
http://dbix-class.org/
11 stars 34 forks source link

do not require MooseX::MarkAsMethods with only_autoclean=1 #21

Closed karenetheridge closed 5 years ago

karenetheridge commented 6 years ago

When use_moose=1 and only_autoclean=1, we do not require MooseX::MarkAsMethods, but require a more recent version of Moose. Check for whichever set of prereqs is appropriate.

Technically, we don't need MXMAM at all if Moose is at 2.1400, but the generated code will still (for now) use the MXMAM constructs if only_autoclean is not set. This gives the user more flexibility if their Moose installation isn't at a new enough version on all systems.

karenetheridge commented 6 years ago

Looks like travis succeeded, except for some transient network hiccups.

ilmari commented 5 years ago

Thanks, merged in 6d0f96209ca74e7bc0857df2ce3a78b7f15a5ce9

karenetheridge commented 5 years ago

many thanks!