Oracle producer add missing functions

hazardv commented 2 years ago

Adds functionality to Producer/Oracle.pm to:

Alter create constraints
Alter drop constraints
Drop fields
Drop tables
Alter create index
Alter drop index

Related tests have been added to prove changes and all existing tests pass. Automatic creation of trigger to insert sysdate to all timestamp fields has been commented out. That should not be done automatically.

Changes were modeled after the structure of Producer/MySQL.pm.

This branch also includes changes from pull request #142

hazardv commented 2 years ago

@mohawk2 The code you reviewed was from a few commits back. This is the first time I am attempting to contribute to a project like this so I am betting that I messed a few things up.

I have been using DBIx::Class and DBIx::Class::Schema::Versioned for another project and while working on that I discovered functionality that was missing from the Oracle producer. I added in the missing functionality and submitted the pull request. I continued with my project, made changes to the data model, attempted to generate the DDL, and discovered a few more things missing from the Oracle producer. So I added those things into the same branch because it seemed reasonable and pushed the changes. I did that whole process one more time and now I am like 97% sure that all of the missing functionality has been implemented and I won't make any more changes to the branch.

Please check out the latest commit b14da74 and let me know if you see any issues.

mohawk2 commented 1 year ago

Thanks for the updates.

The current list of commits sort of meanders, which isn't a criticism, but does highlight a possible process-improvement, especially to help reviewers. Since this is on a branch belonging to you, it's safe to force-push it. The way I work is to end up with the branch I'm making having a series of small commits, each of which meaningfully transforms the starting code towards the desired end-state. This often involves squashing together (using rebase "fixup" command) previous versions of a change, with a correction. This means the final list of commits doesn't have things like commented code, then removal of that (as here). Having adjusted the list of commits to a new one, you'd then need to force-push it.

The alternative (which isn't fatal) is that this set of commits will either (if merged in as-is) be slightly untidy for future people looking to see why a piece of code is as it is, or (if squash-merged) a single quite large commit which can take longer to comprehend.

Tagging in @rabbiveesh.