Closed rabbiveesh closed 1 year ago
Oooh, good call. Will update when I have the chance
On Sun, Oct 2, 2022, 02:41 mohawk2 @.***> wrote:
@.**** commented on this pull request.
In .github/workflows/linux.yml https://github.com/dbsrgits/sql-translator/pull/147#discussion_r985157195 :
- '5.32'
- '5.34'
- '5.36' container: image: perl:${{ matrix.perl-version }} steps:
- uses: @.***
- name: perl -V
- run: perl -V
- name: Install early dep
- run: cpanm -n File::ShareDir::Install
- name: dev packages for testing
- run: apt update && apt install -y libgd-dev graphviz libxml2-dev
- name: Install early + extra deps
- run: cpanm -n File::ShareDir::Install DBD::SQLite CGI
Would it be better to add DBD::SQLite CGI to the develop-requires? FSDI needs to be there so the Makefile.PL will run.
— Reply to this email directly, view it on GitHub https://github.com/dbsrgits/sql-translator/pull/147#pullrequestreview-1127576096, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFURPKUHULKWK7D4OZNXYOTWBDD2JANCNFSM6AAAAAAQ2T45PI . You are receiving this because you authored the thread.Message ID: @.***>
all right! there are more improvements to be had, but now it actually works!
this PR corrects our naivete in our previous CI PR