dbsrgits / sql-translator

SQL::Translator (SQLFairy)
http://sqlfairy.sourceforge.net/
82 stars 91 forks source link

Possible precedence problem between ! and string eq #175

Closed eserte closed 2 weeks ago

eserte commented 1 month ago

With bleadperl (e.g. 5.41.5) there are new warnings which are visible while running the test suite:

...
PERL_DL_NONLAZY=1 "/opt/perl-5.41.5/bin/perl5.41.5" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
Possible precedence problem between ! and string eq at /home/cpansand/.cpan/build/2024102323/SQL-Translator-1.65-0/blib/lib/SQL/Translator/Schema/Trigger.pm line 359.
t/02mysql-parser.t ...................... ok
Possible precedence problem between ! and string eq at /home/cpansand/.cpan/build/2024102323/SQL-Translator-1.65-0/blib/lib/SQL/Translator/Schema/Trigger.pm line 359.
t/03mysql-to-oracle.t ................... ok
Possible precedence problem between ! and string eq at /home/cpansand/.cpan/build/2024102323/SQL-Translator-1.65-0/blib/lib/SQL/Translator/Schema/Trigger.pm line 359.
... etc ...

SQL-Translator's own test suite does not fail because of this, but other modules based on SQL::Translator may fail if using something like Test::NoWarnings or similar. Known such modules are:

mauke commented 2 weeks ago

... and

rabbiveesh commented 2 weeks ago

Ah, I'll get to this later today; sorry for the lack of availability

On Wed, Nov 13, 2024, 22:47 mauke @.***> wrote:

... and

  • ABELTJE/Test-DBIC-SQLite-1.01.tar.gz

— Reply to this email directly, view it on GitHub https://github.com/dbsrgits/sql-translator/issues/175#issuecomment-2474750864, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFURPKSS7XUW5O5I4Z74BKL2AO3ETAVCNFSM6AAAAABQV3LIB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZUG42TAOBWGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>